Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kapowbang: rename from kapow #99427

Merged
merged 1 commit into from Oct 3, 2020
Merged

kapowbang: rename from kapow #99427

merged 1 commit into from Oct 3, 2020

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Oct 2, 2020

Motivation for this change

kapow is an established name of an older project, being packaged in #78407.
Repology and ArchLinux call the Go project kapowbang because its name is "Kapow!":
https://github.com/BBVA/kapow
https://repology.org/projects/?search=kapow
https://aur.archlinux.org/packages/?K=kapow
Kapow! was packaged as kapow in #88458.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc maintainer @nilp0inter

@orivej
kapowbang: rename from kapow
86e9142 
kapow is an established name of an older project, being packaged in NixOS#78407.
Repology and ArchLinux call the Go project kapowbang because its name is "Kapow!":
https://github.com/BBVA/kapow
https://repology.org/projects/?search=kapow
https://aur.archlinux.org/packages/?K=kapow
@AndersonTorres
Copy link
Member

There is no package associated with it?

@orivej
Copy link
Contributor Author

orivej commented Oct 2, 2020

This PR will allow #78407 to add kapow.

@AndersonTorres
Copy link
Member

Ok then.

@ofborg ofborg bot requested a review from kalbasit October 3, 2020 03:15
@AndersonTorres
Copy link
Member

Why OfBorg is slow? 12 hours!

@nilp0inter
Copy link
Contributor

LGTM

@AndersonTorres AndersonTorres merged commit d191ee2 into NixOS:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @AndersonTorres @nilp0inter