Fix: Check ObjC files as other source files #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You explain what this fixes, but not why this route. Why not fix the NFO files not to have the white space the checker triggers on? |
|
NFO files are generated by nml, and I don't think it's easy to not output extra spaces there. |
|
Sounds like this is a bug in NML and should be fixed there. I have a hard time believing stripping trailing whitespaces is difficult tbh :p |
|
Yeah seems it was easier than I though (see OpenTTD/nml#164). I'll remove the first commit. |
glx22
changed the title
LordAro
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFO files used for nml regression check can contain trailing whitespaces, and commit checker doesn't know that. This PR disable trailing whitespaces checks for these files.Also, while reading the diff checker, I noticed ObjC source files of OpenTTD were skipped for most code style checks, so I fixed it.