Eigen over master #721
Eigen over master #721
Conversation
1. We are making FoldConstants first, so we are copying less amount of data in DeepCopyWithParamsAsPointers. 2. Since we already perform DeepCopyWithParamsAsPointers, PartialWrt already produces params as pointers
|
The CI build is failing because of missing dependency? What do I need? What version? and where should it live? |
|
I have no idea how to make CI happy. The problem is what I use Windows, but CI failed for linux. I have Ubuntu only as virtual machine, but have no time to deal with it. |
|
@Evil-Spirit I was able to manually merge the 1st, 4th, and 5th changes listed above. That can be found here: I'm tempted to merge that to master if you're OK with that. They are performance related but don't involve Eigen. |
@jwesthues or should I not do that? Merging mine would attribute them to me in the log. |
|
I haven't reviewed in detail, but the commits make sense to me conceptually. |
|
Maybe switch https://github.com/RLovelett/eigen.git to https://gitlab.com/libeigen/eigen.git may help? |
@77maxikov Yeah that link is returning a 404. @Evil-Spirit can you change that URL in CMakeLists.txt to the new eigen over at gitlab as shown in the previous comment and push that to your branch. It should automatically come here and trigger a new CI build. |
phkahler
force-pushed
the
master
branch
2 times, most recently
from
dfb96de to
3f09eaf
Compare
No description provided.