Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.bip_utils: 1.4.0 -> 1.5.0 #99419

Merged
merged 1 commit into from Oct 2, 2020
Merged

python3Packages.bip_utils: 1.4.0 -> 1.5.0 #99419

merged 1 commit into from Oct 2, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Oct 2, 2020 •
edited

Motivation for this change

Version update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

mweinelt commented Oct 2, 2020

The change itself LGTM. Can you move the src to fetchFromGitHub and try to enable tests?

Result of nixpkgs-review pr 99419 1

2 packages built:
  • python37Packages.bip_utils
  • python38Packages.bip_utils

@prusnak
python3Packages.bip_utils: 1.4.0 -> 1.5.0
f1057db 
fetch sources from GitHub instead of PyPI to enable tests
@prusnak
Copy link
Member Author

prusnak commented Oct 2, 2020

@mweinelt tests enabled in f1057db

@mweinelt mweinelt merged commit 1a5bbec into NixOS:master Oct 2, 2020
@prusnak prusnak deleted the bip_utils branch October 2, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @mweinelt