Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.crccheck: 0.6 -> 1.0 #99446

Closed
wants to merge 35 commits into from
Closed

python3Packages.crccheck: 0.6 -> 1.0 #99446

wants to merge 35 commits into from

Conversation

etu
Copy link
Contributor

@etu etu commented Oct 3, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflict.

pkgs/development/python-modules/crccheck/default.nix Outdated Show resolved Hide resolved
@etu
Copy link
Contributor Author

etu commented Jan 18, 2021

Rebased on master :)

I had forgot about this PR.

@etu
Copy link
Contributor Author

etu commented Jan 19, 2021

@ofborg eval

@etu etu force-pushed the python-crccheck-update branch 2 times, most recently from af2a40b to 195fc31 Compare January 19, 2021 13:28
SuperSandro2000 and others added 18 commits January 19, 2021 14:34
@SuperSandro2000
Merge pull request NixOS#109959 from SFrijters/tangram-pkg-config
18fa3ee 
tangram: Use pkg-config instead of pkgconfig
@SuperSandro2000
Merge pull request NixOS#109856 from r-ryantm/auto-update/gtk-layer-s…
ec49761 
…hell

gtk-layer-shell: 0.5.1 -> 0.5.2
@SuperSandro2000
Merge pull request NixOS#109857 from r-ryantm/auto-update/halfempty
59abddb 
halfempty: 0.30 -> 0.40
@SuperSandro2000
Merge pull request NixOS#109858 from r-ryantm/auto-update/hebcal
abcd2c1 
hebcal: 4.22 -> 4.24
@SuperSandro2000
Merge pull request NixOS#109860 from r-ryantm/auto-update/helmfile
22a7925 
helmfile: 0.135.0 -> 0.137.0
@SuperSandro2000
Merge pull request NixOS#109859 from r-ryantm/auto-update/heimer
48790c0
@SuperSandro2000
Merge pull request NixOS#109861 from r-ryantm/auto-update/helmsman
fd7ecd2 
helmsman: 3.6.2 -> 3.6.3
@SuperSandro2000
Merge pull request NixOS#109864 from r-ryantm/auto-update/i3lock-color
bc73d42 
i3lock-color: 2.12.c.5 -> 2.13.c.1
@SuperSandro2000
Merge pull request NixOS#109865 from r-ryantm/auto-update/igmpproxy
ec3c0d8 
igmpproxy: 0.2.1 -> 0.3
@SuperSandro2000
Merge pull request NixOS#109866 from r-ryantm/auto-update/indilib
0a6bfdf 
indilib: 1.8.7 -> 1.8.8
@SuperSandro2000
Merge pull request NixOS#109869 from r-ryantm/auto-update/istioctl
3541f0b 
istioctl: 1.8.1 -> 1.8.2
@SuperSandro2000
Merge pull request NixOS#109877 from r-ryantm/auto-update/jx
5faea62 
jx: 2.1.149 -> 2.1.155
@SuperSandro2000
Merge pull request NixOS#109878 from r-ryantm/auto-update/k4dirstat
5f8d2ca 
k4dirstat: 3.2.1 -> 3.2.2
@SuperSandro2000
Merge pull request NixOS#109879 from r-ryantm/auto-update/kanboard
71662c7 
kanboard: 1.2.16 -> 1.2.18
@SuperSandro2000
Merge pull request NixOS#109888 from zakame/updates/bpytop-1.0.59
a68cdb5 
bpytop: 1.0.50 -> 1.0.59
@SuperSandro2000
Merge pull request NixOS#109889 from r-ryantm/auto-update/aws-sdk-cpp
83a24a7 
aws-sdk-cpp: 1.8.113 -> 1.8.121
@SuperSandro2000
Merge pull request NixOS#109891 from r-ryantm/auto-update/belcard
bd89409 
belcard: 4.4.13 -> 4.4.24
@etu
python3Packages.crccheck: 0.6 -> 1.0
77ab38b
@etu
Copy link
Contributor Author

etu commented Jan 19, 2021

That eval error doesn't look like my fault, rebasing and reevaling.

@ofborg eval

@etu etu closed this Jan 19, 2021
@etu etu mentioned this pull request Jan 19, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@etu @SuperSandro2000 @r-ryantm @zakame @SFrijters