Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xsecurelock: Add missing libraries #99428

Closed
wants to merge 1 commit into from
Closed

xsecurelock: Add missing libraries #99428

wants to merge 1 commit into from

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Oct 2, 2020 •
edited

According to configure.ac from xsecurelock:

I tried to add this to see if it would fix the INCOMPATIBLE COMPOSITOR error when using with picom. This didn't work, but since I already had the trouble of trying this and it does seem that this improve the program in some way, I decided to open this PR.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
xsecurelock: Add missing libraries
8958256 
According to `configure.ac` from xsecurelock:

- The XFixes extension is used to work around possible weird leftover state
from compositors.
- This extension (Xxf86misc) doesn't really exist anymore, but served to
counteract the (also no longer existing) AllowClosedownGrabs and similar X
server settings.
@thiagokokada
Copy link
Contributor Author

@fpletz.

@ofborg ofborg bot requested a review from fpletz October 3, 2020 03:43
@thiagokokada thiagokokada deleted the add-more-missing-xsecurelock-libs branch November 7, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@thiagokokada