Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aldo: 0.7.7 -> 0.7.8 #99444

Merged
merged 1 commit into from Oct 28, 2020
Merged

aldo: 0.7.7 -> 0.7.8 #99444

merged 1 commit into from Oct 28, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Oct 3, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bennyandresen
bennyandresen approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@bennyandresen bennyandresen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds (and resulting bin runs)

stigtsp
stigtsp approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99444 1

1 package built:
  • aldo

@stigtsp stigtsp merged commit 4512dac into NixOS:master Oct 28, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/265

AluisioASG
AluisioASG reviewed Oct 28, 2020
View reviewed changes
pkgs/applications/radio/aldo/default.nix

stdenv.mkDerivation rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a particular reason for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to not have recursive attribute sets where variables can be borrowed and used anywhere, it makes the scope more confusing than a let block :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, not a style I see often. Thanks for explaining!

@etu etu deleted the aldo-upgrade branch October 28, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AluisioASG AluisioASG AluisioASG left review comments

@stigtsp stigtsp stigtsp approved these changes

@bennyandresen bennyandresen bennyandresen approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@etu @nixos-discourse @stigtsp @bennyandresen @AluisioASG