Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p11-kit: fix tests when non-root #99437

Merged
merged 1 commit into from Oct 18, 2020
Merged

p11-kit: fix tests when non-root #99437

merged 1 commit into from Oct 18, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Oct 3, 2020 •
edited

On non-nixos linux using nix in non-root single-user mode,
this prevents:
ERROR: test-conf - missing test plan

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-burns r-burns changed the base branch from master to staging October 3, 2020 05:55
@r-burns
Copy link
Contributor Author

r-burns commented Oct 3, 2020

Ugh, sorry for mass notification. I'll just close and reissue next time 😞

@zowoq zowoq removed their request for review October 3, 2020 06:17
vcunat
vcunat approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a single-user installation at hand, but why not...

@vcunat vcunat merged commit f42d36d into NixOS:staging Oct 18, 2020
@r-burns r-burns deleted the p11-kit branch October 18, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-burns @vcunat