Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: create options for smaller derivation #98998

Merged
merged 1 commit into from Oct 10, 2020

Conversation

Kloenk
Copy link
Member

@Kloenk Kloenk commented Sep 28, 2020

Motivation for this change

Base work for #98299

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Sep 30, 2020

@Kloenk any chance you could keep this udev = systemd (but update the comment)? Maybe that's also what fails evaluation currently.

Otherwise I'd also gladly massage this in shape :-)

@Kloenk
Copy link
Member Author

Kloenk commented Sep 30, 2020

I can change that. But bigger changes have to wait a little. (School takes much time currently)

@Kloenk
Copy link
Member Author

Kloenk commented Sep 30, 2020

@flokli
replace, or add to the comment?

@flokli
Copy link
Contributor

flokli commented Sep 30, 2020

I'd propose to have that line look like this:

 udev = systemd; # TODO: change to systemdMinimal

So this shouldn't cause any breakage, and we have systemdMinimal available for other tasks.

I can change that. But bigger changes have to wait a little. (School takes much time currently)

No worries!

@flokli
Copy link
Contributor

flokli commented Sep 30, 2020

Sorry, I missed this - this is a mass rebuild, so it'll need to target staging.

@flokli flokli added this to To Do in systemd via automation Sep 30, 2020
@flokli flokli moved this from To Do to In Progress in systemd Sep 30, 2020
@Kloenk Kloenk changed the base branch from master to staging September 30, 2020 16:28
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with all our recent systemd decisions. But this PR makes sense to me, and I'm eager to try out homed in the one that depends on it.

@Kloenk says the ofborg failure doesn't reproduce locally, so I suspect this is due to ofborg merging a broken master/staging.

@Kloenk
Copy link
Member Author

Kloenk commented Oct 8, 2020

rebased, hopefully this fixes ofborg-eval

Co-Authored-By: Kirill Elagin <kirelagin@gmail.com>
@Ericson2314
Copy link
Member

Ah good with the udev = systemd; # TODO: change to systemdMinimal this really is quite minimal. I'll just merge then.

In any event, I'm always for exposing more flags on the nix expr level. It gives gentoo people less reason to complain about us :D.

@Ericson2314 Ericson2314 merged commit db3b1c1 into NixOS:staging Oct 10, 2020
systemd automation moved this from In Progress to Done Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
systemd
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants