Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octoprint dashboard maintainers #99010

Closed
wants to merge 2 commits into from
Closed

Octoprint dashboard maintainers #99010

wants to merge 2 commits into from

Conversation

j0hax
Copy link
Member

@j0hax j0hax commented Sep 28, 2020 •
edited

Motivation for this change

Updated expression to reflect a change in maintainership.

I've also updated the package of its optional dependency OctoPrint-DisplayLayerProgress.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@j0hax j0hax marked this pull request as ready for review October 1, 2020 18:09
@j0hax j0hax mentioned this pull request Oct 8, 2020
Merged
10 tasks
@j0hax
Copy link
Member Author

j0hax commented Oct 8, 2020

Closing because #99998 already includes newer releases.

@j0hax j0hax closed this Oct 8, 2020
@j0hax j0hax deleted the octoprint-dashboard-maintainers branch October 8, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@j0hax