Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance and Donate page redesign #588

Merged
merged 44 commits into from Oct 22, 2020
Merged

Governance and Donate page redesign #588

merged 44 commits into from Oct 22, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Sep 28, 2020 •
edited

Goverance page

Design

TODO

  • "Learn more" link in RFC process section should be green button (@garbas)
  • new image for rfc process, recreate in inkscape (@samueldr)
  • ‼️ dark blue diagonal background for Teams section (@samueldr)
  • icons for teams (need export from the design @garbas)
  • design team listing, font and green button (@garbas)
  • add "NixOS foundation" logo missing in mission statement (@samueldr)
  • design listing of board members as in design (@garbas)
  • design Team pages (@garbas)

Donate page

Design

TODO

  • ‼️ vertical "NixOS Foundation" logo, needs some inkscape work (@samueldr)
  • diagonal light blue background for stores section (@samueldr)
  • image of some fictional character wearing NixOS t-shirt (designer via @garbas)
  • add both stores to the store section (@garbas)
  • prepare text for open collective (@garbas)
  • 3 columns for sponsors in Acknowledgements section, also size of images should be the same (@garbas)

This change is Reviewable

@garbas garbas added the design About the design refresh work label Sep 28, 2020
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f7201283961d3f3b9a2cfc3--nixos-homepage.netlify.app

@garbas garbas changed the title donate.html: initial structure and text WIP: Donate page redesign Sep 28, 2020
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f72409d16199198a88eb302--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f724b525973e25611815d07--nixos-homepage.netlify.app

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/marketing-team-meeting-minutes-14/9304/1

@garbas garbas mentioned this pull request Oct 7, 2020
Closed
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f85abdf4faec81a087e6a88--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f85da671250bd43d244dfcc--nixos-homepage.netlify.app

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/hello-tux-shirts/7979/15

@garbas
add some description for open collective
47bec24 
and add, but comment out HelloTux shop
@samueldr
governance.tt: Remove troublesome word
4316c8e 
With text replacement, that text ends up being the *semantic* text. This
is not like alt text where you would have the screen reader describe
that it is attached to an image.
@samueldr
site-style: Use the foundation text
07ce94c
@samueldr
Copy link
Member

‼️ The foundation logo has been implemented in #589

@garbas garbas changed the title Donate page redesign Governance and Donate page redesign Oct 20, 2020
@garbas
Copy link
Member Author

garbas commented Oct 20, 2020

I merge #589 and master ... we have only few things left to finish this PR.

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f8f378d7c41a440e2388a1e--nixos-homepage.netlify.app

@samueldr
Copy link
Member

icons for teams (need export from the design @garbas)

Are the icons from the PDF not okay? If they are I can try extracting them, chances are it'll work just fine since it's not a complicated bit in the PDF.

Yes the icons are good from the PDF just I don't know how to extract them.

Good, I'll handle exporting them at the very least.

The gist of it is importing the PDF in inkscape, it will generally handle things fine. Though sometimes it requires a bit of cleanup for things like reducing the amount of points by "simplifying" the paths, and such, so the files end up smaller. Ideally, one would also try to "pixel-snap" lines so they don't end up fuzzy if shown at 1:1 scale.

@samueldr
site-styles: Add assets used in governance page
a1e99bf 
Names are given in a generic manner as they are not strictly *for* the
governance page.
@samueldr
Copy link
Member

samueldr commented Oct 21, 2020 •
edited

The graphical elements have been extracted, only. They are "face12"'d so they can be coloured with svg.less. If you need more help for them just ask.

They're all exported with 138×138px bounding boxes, so you can apply them to element "centered and contained" and they will be the right scale comparative to each other.

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f90a6fc53ac913eeaea15f4--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f90ba4fa1dab26311cfd22f--nixos-homepage.netlify.app

davidak
davidak suggested changes Oct 22, 2020
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall it looks very good. well done!

donate.tt Outdated Show resolved Hide resolved
donate.tt Show resolved Hide resolved
donate.tt
</li>
<li>
<a href="https://www.fastly.com/">
<img src="[% root %]logo/fastly.png" alt="Fastly" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fastly logo is bigger than the box

Screenshot from 2020-10-22 17-55-04

leading to glitches

Screenshot from 2020-10-22 17-55-49

Copy link
Member Author

@garbas garbas Oct 22, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidak how can I reproduce the glitch?

Copy link
Member

@davidak davidak Oct 22, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open in browser? i mean that the white space around the fastly is not a rectangle like the other, but the corners are cut out, like you see in the screenshot

you see it even more now

Screenshot from 2020-10-22 21-58-38

the images should all have the same 2px(?) border

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f91d149dc7d6c2277bfe7c1--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f91d169f36328181ee68410--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f91d1aa6cdf4b1c8de2f8b5--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f91d242b20a6300851d58ba--nixos-homepage.netlify.app

@garbas garbas merged commit af6e932 into master Oct 22, 2020
@garbas garbas deleted the redesign-donate branch October 22, 2020 18:44
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-4/9862/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak requested changes

@samueldr samueldr Awaiting requested review from samueldr

Assignees
No one assigned
Labels
design About the design refresh work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garbas @nixos-discourse @samueldr @davidak