Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance page redesign #589

Closed
wants to merge 20 commits into from
Closed

Governance page redesign #589

wants to merge 20 commits into from

Conversation

garbas
Copy link
Member

@garbas garbas commented Sep 28, 2020 •
edited by samueldr

Design

TODO

  • "Learn more" link in RFC process section should be green button (@garbas)
  • new image for rfc process, recreate in inkscape (@samueldr)
  • ‼️ dark blue diagonal background for Teams section (@samueldr)
  • icons for teams (need export from the design @garbas)
  • design team listing, font and green button (@garbas)
  • add "NixOS foundation" logo missing in mission statement (@samueldr)
  • design listing of board members as in design (@garbas)
  • design Team pages (@garbas)

This change is Reviewable

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f7206d4a42cb5fcb6b36766--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f7208c00684ae02dc94602b--nixos-homepage.netlify.app

@garbas garbas added the design About the design refresh work label Sep 28, 2020
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f7240bf16199195cc8eb477--nixos-homepage.netlify.app

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/marketing-team-meeting-minutes-14/9304/1

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2020

🚀 Deployed on https://5f7fba324b483c14a1a2dfcb--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2020

🚀 Deployed on https://5f7fcff3c0eea13b79d44103--nixos-homepage.netlify.app

@garbas garbas changed the title WIP: Governance page redesign Governance page redesign Oct 12, 2020
@garbas garbas changed the title Governance page redesign WIP: Governance page redesign Oct 12, 2020
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f84485c61a5d0a23331668c--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f8494354f6dfd0086ae2487--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f84beb8c889ab3146ba42eb--nixos-homepage.netlify.app

@garbas garbas changed the title WIP: Governance page redesign Governance page redesign Oct 13, 2020
@garbas garbas requested a review from samueldr October 13, 2020 13:23
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f85ab3ad2f66913541f6d61--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f85abbf4048a4164ed12051--nixos-homepage.netlify.app

@samueldr
common.tt: Add helper to inline SVG correctly
857fe64 
The issue comes from a proper SVG having the <?xml > declaration. This
is proper.

What is wrong is having that declaration anywhere else in the document!!

So we're now stripping it from SVG documents being inlined.
@samueldr
governance.less: Inline the SVG diagram
c0a8912 
Why inline? FONTS!

Otherwise we have to bake in the font outlines as fonts won't follow
through <img /> or background image inclusions.
@samueldr
rfc-process.svg: Add source and plain svg export
33cb317
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f8e3f5d6b7e614fabfb0206--nixos-homepage.netlify.app

@samueldr
Copy link
Member

samueldr commented Oct 20, 2020 •
edited

‼️ dark blue diagonal background for Teams section (@samueldr)

This has been mostly implemented in #588;

I can do the changes if you're not comfortable doing them, once we have that merged in master and master merged in this PR.

@samueldr
Copy link
Member

icons for teams (need export from the design @garbas)

Are the icons from the PDF not okay? If they are I can try extracting them, chances are it'll work just fine since it's not a complicated bit in the PDF.

@samueldr
site-styles: Add foundation text
991a4c6
@samueldr
governance.tt: Remove troublesome word
4316c8e 
With text replacement, that text ends up being the *semantic* text. This
is not like alt text where you would have the screen reader describe
that it is attached to an image.
@samueldr
site-style: Use the foundation text
07ce94c
@samueldr
Copy link
Member

Given that now #588 lightly depends on this one for the Foundation logo, how should we proceed?

@samueldr samueldr mentioned this pull request Oct 20, 2020
Merged
14 tasks
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f8e46a0664a616413d4e2c9--nixos-homepage.netlify.app

@garbas
Copy link
Member Author

garbas commented Oct 20, 2020

I'm going to close this PR and merge this work into #588. Then both pages are going to land at the same time

@garbas garbas closed this Oct 20, 2020
@garbas
Copy link
Member Author

garbas commented Oct 20, 2020

icons for teams (need export from the design @garbas)

Are the icons from the PDF not okay? If they are I can try extracting them, chances are it'll work just fine since it's not a complicated bit in the PDF.

Yes the icons are good from the PDF just I don't know how to extract them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr Awaiting requested review from samueldr

Assignees
No one assigned
Labels
design About the design refresh work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garbas @nixos-discourse @samueldr