Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dub: 1.14.0 -> 1.22.0 #96969

Closed
wants to merge 1 commit into from
Closed

dub: 1.14.0 -> 1.22.0 #96969

wants to merge 1 commit into from

Conversation

mklca
Copy link
Contributor

@mklca mklca commented Sep 2, 2020 •
edited

Motivation for this change

Update to latest upstream

Things done

stop relying on deprecated build.sh script

remove tests that rely on network access or local maven

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/9hyfma4siw4wkwhrpx30xgrla9p3laa5-dub-1.14.0 692104968
/nix/store/r1v73npv5qr17wa8ws1dwvrdzhk3xpf2-dub-1.22.0 692290624

@mklca
dub: 1.14.0 -> 1.22.0
81e0983 
stop relying on deprecated `build.sh` script

remove tests that rely on network access or local maven
@mklca
Copy link
Contributor Author

mklca commented Sep 2, 2020

nixpkgs-review passes after fixing Literate for the current version of dmd in Nixpkgs.

Literate is already broken in the current Nixpkgs master. 🤷‍♀️

@mklca
Copy link
Contributor Author

mklca commented Sep 2, 2020

Fixed after #96978 is merged to unbreak Literate

@SuperSandro2000
Copy link
Member

@mklca please fix the merge conflict.

@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@siraben siraben closed this Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mklca @SuperSandro2000 @siraben