Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpvScripts.youtube-quality: init at unstable-2020-02-11 #96983

Closed

Conversation

samuelgrf
Copy link
Member

@samuelgrf samuelgrf commented Sep 2, 2020

Motivation for this change

mpv-youtube-quality is an mpv script for changing YouTube video quality (ytdl-format) on the fly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samuelgrf
Copy link
Member Author

Converting this to a draft until a license is added to the project, see jgreco/mpv-youtube-quality#17

@samuelgrf samuelgrf force-pushed the initpkg/mpv-youtube-quality branch 4 times, most recently from 587dd83 to b7a3401 Compare September 5, 2020 12:39
@samuelgrf
Copy link
Member Author

@GrahamcOfBorg eval

@samuelgrf
Copy link
Member Author

Closing because I am not using the package anymore.

@samuelgrf samuelgrf closed this Mar 29, 2021
@samuelgrf samuelgrf deleted the initpkg/mpv-youtube-quality branch March 5, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant