Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

croc: 8.0.13 -> 8.3.0 #96994

Merged
merged 1 commit into from Sep 4, 2020
Merged

croc: 8.0.13 -> 8.3.0 #96994

merged 1 commit into from Sep 4, 2020

Conversation

equirosa
Copy link
Contributor

@equirosa equirosa commented Sep 3, 2020

Motivation for this change

New version released: https://github.com/schollz/croc/releases/tag/v8.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
NOTE: using the --version flag with this new release yields the following output:
croc version v8.1.3-2096751

However, running croc send -h presents options only available in the 8.2.0 version.

@ofborg ofborg bot requested review from HugoReeves and kalbasit September 3, 2020 05:43
@equirosa
Copy link
Contributor Author

equirosa commented Sep 3, 2020

New release today: https://github.com/schollz/croc/releases/tag/v8.2.1

HugoReeves
HugoReeves approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@HugoReeves HugoReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds and executes on Darwin

@ofborg ofborg bot requested a review from HugoReeves September 3, 2020 20:41
@equirosa
Copy link
Contributor Author

equirosa commented Sep 4, 2020

Another new release, containing four fixes: https://github.com/schollz/croc/releases/tag/v8.3.0

@equirosa equirosa changed the title croc: 8.0.13 -> 8.2.0 croc: 8.0.13 -> 8.3.0 Sep 4, 2020
@ofborg ofborg bot requested a review from HugoReeves September 4, 2020 03:52
HugoReeves
HugoReeves approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@HugoReeves HugoReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zowoq zowoq merged commit 476216e into NixOS:master Sep 4, 2020
@equirosa equirosa deleted the croc branch September 4, 2020 04:04
@equirosa equirosa restored the croc branch September 4, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HugoReeves HugoReeves HugoReeves approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@equirosa @HugoReeves @zowoq