Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

black-macchiato: init at 1.3.0 #96976

Merged
merged 2 commits into from Sep 3, 2020
Merged

black-macchiato: init at 1.3.0 #96976

merged 2 commits into from Sep 3, 2020

Conversation

jperras
Copy link
Contributor

@jperras jperras commented Sep 2, 2020 •
edited

Motivation for this change

Adds the Python package black-macchiato, which allows the usage of Python's black formatter for subsets of an entire file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Sep 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/python-modules/black-macchiato/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/black-macchiato/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/black-macchiato/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

@jperras thanks for opening your first PR against nixpkgs :)

@jperras
black-macchiato: init at 1.3.0
4d7a17f 
Adds the Python package `black-macchiato`, which allows the usage of
`black` for subsets of an entire file.
@jperras
maintainers: add jperras
df82c70
jonringer
jonringer approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96976 1

2 packages built:
  • black-macchiato (python38Packages.black-macchiato)
  • python37Packages.black-macchiato

@jonringer jonringer merged commit 80f1cc1 into NixOS:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jperras @jonringer @Janik-Haag