Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openocd: 0.10.0 -> 2020-09-02 #97018

Merged
merged 1 commit into from Sep 17, 2020
Merged

openocd: 0.10.0 -> 2020-09-02 #97018

merged 1 commit into from Sep 17, 2020

Conversation

evils
Copy link
Member

@evils evils commented Sep 3, 2020

Motivation for this change

latest release is 3.5 years old but the project is still active

Things done
  • bump the commit to the latest revision

  • verified the patch has been upstreamed

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

    • 243157280 -> 243982256
  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

latest release is 3.5 years old but the project is still active
@bjornfor
Copy link
Contributor

bjornfor commented Sep 3, 2020

+1 to ask upstream to make a release. (Is there a reason they're not making another release in so long time? Do they even want to be packaged in linux distros? Is it OK to package "any given snapshot" from master?)

@evils
Copy link
Member Author

evils commented Sep 4, 2020

there is an upstream issue about their release status
https://sourceforge.net/p/openocd/tickets/277/

i believe using their git master branch is common practice
there's even a project calling it a rolling release now (though i haven't found a primary reference for that)
(i think i saw one of the openocd contributors mention master works for them, and calling making release notes tedious)

Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openocd builds & runs, macos 10.14. Reverse dependency tinygo doesn't, but it seems to be already broken on darwin.

Both build & run, non-nixos linux x86_64.

@Lassulus Lassulus merged commit b19f679 into NixOS:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants