Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkl: 2020.2.254 -> 2020.3.279 #97019

Merged
merged 1 commit into from Sep 7, 2020
Merged

mkl: 2020.2.254 -> 2020.3.279 #97019

merged 1 commit into from Sep 7, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Sep 3, 2020

Motivation for this change

Release notes:

https://software.intel.com/content/www/us/en/develop/articles/intel-math-kernel-library-release-notes-and-new-features.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
Copy link
Contributor Author

danieldk commented Sep 7, 2020

I have used this wit PyTorch on various machines without any issues so far.


# Replace `openmpSpot` by `spot` after 2020.3. Release 2020.03
# adresses performance regressions and does not update OpenMP.
openmpSpot = if stdenvNoCC.isDarwin then spot else "2";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice comment explaining what's going on here! 👍

@bhipple
Copy link
Contributor

bhipple commented Sep 7, 2020

Result of nixpkgs-review pr 97019 1

5 packages built:
- clmagma
- mkl
- python27Packages.mkl-service
- python37Packages.mkl-service
- python38Packages.mkl-service

@bhipple bhipple merged commit 3c43357 into NixOS:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants