Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move KnightOS packages into pkgs/tools/knightos #97013

Merged
merged 1 commit into from Sep 6, 2020
Merged

Move KnightOS packages into pkgs/tools/knightos #97013

merged 1 commit into from Sep 6, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Sep 3, 2020

Motivation for this change

Addresses #95979

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
Copy link
Contributor

danieldk commented Sep 6, 2020

I pushed a change to prefix the keys with knightos- as discussed in that issue. Did that now, to avoid that we have the unprefixed names in 20.09, which would then mean breaking the names in 21.03 and we'd have to add aliases, etc.

danieldk
danieldk approved these changes Sep 6, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 97013 1

4 packages built:
  • knightos-kimg
  • knightos-kpack
  • knightos-mkrom
  • knightos-scas

@danieldk danieldk merged commit 53a3f7a into NixOS:master Sep 6, 2020
@siraben siraben deleted the knightos-tools branch September 6, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @danieldk