Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smartgit: 19.1.1 -> 20.1.4 #96980

Closed
wants to merge 2 commits into from
Closed

smartgit: 19.1.1 -> 20.1.4 #96980

wants to merge 2 commits into from

Conversation

novafacing
Copy link

Motivation for this change

Smartgit has received updates and will not open in free mode if not kept at latest. I have simply updated the version and updated a requirement that was crashing the app on my system. Prior to replacing jre with jdk11, smartgit crashed with error "GTK+ 2.x symbols detected. Using GTK+ 2.x and GTK+ 3 in the same process is not supported". This is fixed by updating the java dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tomberek
Copy link
Contributor

tomberek commented Sep 6, 2020 

anonymous function at /home/tom/.cache/nixpkgs-review/pr-96980/nixpkgs/pkgs/applications/version-management/smartgithg/default.nix:1:1 called with unexpected argument 'jre', at /home/tom/.cache/nixpkgs-review/pr-96980/nixpkgs/lib/customisation.nix:69:16

@SuperSandro2000
Copy link
Member

@novafacing please fix the eval issue.

@novafacing
Copy link
Author

@SuperSandro2000 I don't have time right this moment (end of semester) but I'll have a fix in in about a week hopefully.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft December 8, 2020 02:03
@SuperSandro2000
Copy link
Member

@ofborg eval

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@siraben siraben closed this Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@novafacing @tomberek @SuperSandro2000 @siraben @Janik-Haag