Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octave: Fix libtool framework link failure on Darwin #96979

Merged
merged 1 commit into from Sep 7, 2020
Merged

octave: Fix libtool framework link failure on Darwin #96979

merged 1 commit into from Sep 7, 2020

Conversation

graham33
Copy link
Contributor

@graham33 graham33 commented Sep 2, 2020 •
edited

Motivation for this change

This fix moves linker flags of the form -framework foo from dependency_libs to
inherited_linker_flags, since libtool doesn't understand them. See #96977 for
details.

There may be a better way to do this, and it's also possible/likely that we could just drop these args from dependency_libs rather than moving them to inherited_linker_flags (which would simplify the implementation considerably). Using inherited_linker_flags was advised here: https://bugreports.qt.io/browse/QTBUG-48575.

Fixes #96977

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 2, 2020
@graham33 graham33 mentioned this pull request Sep 2, 2020
Closed
ttuegel
ttuegel requested changes Sep 6, 2020
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the GitHub interface won't let me rebase your pull request. Please rebase this against the staging branch.

@graham33 graham33 changed the base branch from master to staging September 6, 2020 19:21
@graham33
octave: Fix libtool framework link failure on Darwin
8e4e38c 
This fix moves linker flags of the form `-framework foo` from dependency_libs to
inherited_linker_flags, since libtool doesn't understand them.  See NixOS#96977 for
details.

Fixes NixOS#96977
@graham33
Copy link
Contributor Author

graham33 commented Sep 6, 2020

Rebased on staging.

@ttuegel ttuegel self-requested a review September 7, 2020 19:57
@ttuegel ttuegel merged commit 6805511 into NixOS:staging Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@andir andir Awaiting requested review from andir

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Octave 5.2.0 libtool build failure on Darwin
2 participants
@graham33 @ttuegel