Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Literate: 2019-01-08 -> 2020-09-02 #96978

Closed
wants to merge 1 commit into from
Closed

Literate: 2019-01-08 -> 2020-09-02 #96978

wants to merge 1 commit into from

Conversation

mklca
Copy link
Contributor

@mklca mklca commented Sep 2, 2020

Motivation for this change

Fix compilation of Literate with the current version of dmd in Nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mklca
Copy link
Contributor Author

mklca commented Sep 2, 2020

Can't compare sizes because Literate currently doesn't build.

@doronbehar
Copy link
Contributor

Merge conflicts.

@SuperSandro2000
Copy link
Member

@mklca please resolve the merge conflicts.

@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@doronbehar
Copy link
Contributor

Closing due to no response from OP.

@doronbehar doronbehar closed this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants