Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: Add missing patches to the Emacs derivations #97026

Merged
merged 1 commit into from Sep 3, 2020
Merged

emacs: Add missing patches to the Emacs derivations #97026

merged 1 commit into from Sep 3, 2020

Conversation

DamienCassou
Copy link
Contributor

@DamienCassou DamienCassou commented Sep 3, 2020 •
edited

Motivation for this change

A recent change (967259e) to how Emacs derivations are written introduced a bug: patches are not taken into consideration during the builds anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@DamienCassou
emacs: Add missing patches to the Emacs derivations
556b29d 
patches were removed by a recent refactoring of Emacs packages:

  967259e * emacs: Factor out expression to a generic build
@ofborg ofborg bot added the 6.topic: emacs label Sep 3, 2020
@ofborg ofborg bot requested review from peti and jwiegley September 3, 2020 16:18
@DamienCassou
Copy link
Contributor Author

Result of nixpkgs-review pr 97026 1

2 packages failed to build:
- cedille
- idutils
34 packages built:
- aerc
- afew
- agda
- alot
- astroid
- auctex
- cask
- cflow
- cscope
- emacs
- emacs-nox
- emacs26
- emacs26-nox
- framac
- gcl
- gcl_2_6_13_pre
- lieer (gmailieer)
- meli
- mozart (mozart-binary ,mozart2-binary)
- mozart2
- mu
- muchsync
- neomutt
- notmuch
- notmuch-addrlookup
- pydb
- python27Packages.notmuch
- python37Packages.alot
- python37Packages.notmuch
- python38Packages.notmuch
- recutils
- rtags
- supercollider_scel
- why3

@adisbladis adisbladis merged commit e807447 into NixOS:master Sep 3, 2020
@DamienCassou DamienCassou deleted the add-patches-back-to-emacs branch September 6, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis adisbladis is a code owner

@peti peti Awaiting requested review from peti

@jwiegley jwiegley Awaiting requested review from jwiegley

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DamienCassou @adisbladis