Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hp2p: init at 3.3 #96998

Merged
merged 1 commit into from Aug 26, 2021
Merged

hp2p: init at 3.3 #96998

merged 1 commit into from Aug 26, 2021

Conversation

bzizou
Copy link
Contributor

@bzizou bzizou commented Sep 3, 2020

Motivation for this change

A simple and powerful tool for benchmarking our low latency hpc networks
This package has been successfully used in production as a NUR package (https://github.com/nix-community/nur-combined/tree/master/repos/gricad/pkgs/hp2p) on an Omnipath interconnected cluster running Debian.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! Can you just capitalize meta.homepage? And then this should be good to go :)

pkgs/tools/networking/hp2p/default.nix Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@stale stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Jun 3, 2021
@markuskowa markuskowa self-assigned this Jun 3, 2021
pkgs/tools/networking/hp2p/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/hp2p/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/hp2p/default.nix Show resolved Hide resolved
pkgs/tools/networking/hp2p/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/hp2p/default.nix Outdated Show resolved Hide resolved
@markuskowa
Copy link
Member

@bzizou I think we need a rebase here to fix the coflict in pkgs/top-level/all-packages.nix

@bzizou
Copy link
Contributor Author

bzizou commented Aug 24, 2021

I just forced pushed an updated branch, using python3 and depending on #135534

@markuskowa
Copy link
Member

@bzizou Now that #135534 is merged we can remove mpldatacursor again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants