Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #99709

Merged
merged 465 commits into from Oct 14, 2020
Merged

Staging next #99709

merged 465 commits into from Oct 14, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

volth added 30 commits September 9, 2020 09:13
@vcunat
Copy link
Member

vcunat commented Oct 6, 2020

Note: we should not merge this before getting a nixos-unstable channel update. Currently #99236, channel on a 10 days old commit.

to make the CI happy
@vcunat
Copy link
Member

vcunat commented Oct 8, 2020

The channel was updated to a day-old commit.

@stigtsp stigtsp mentioned this pull request Oct 8, 2020
10 tasks
FRidh and others added 5 commits October 8, 2020 21:47
Quite many rebuilds from master:
> Estimating rebuild amount by counting changed Hydra jobs.
>    3926 x86_64-darwin
>    4645 x86_64-linux
@FRidh FRidh merged commit b3aed16 into master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet