Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notmuch: 0.30.1c80020 -> 0.31 #99712

Merged
merged 1 commit into from Oct 8, 2020
Merged

notmuch: 0.30.1c80020 -> 0.31 #99712

merged 1 commit into from Oct 8, 2020

Conversation

avdv
Copy link
Member

@avdv avdv commented Oct 6, 2020 •
edited

Motivation for this change

New upstream release: https://notmuchmail.org/news/release-0.31/

ZHF: #97479

Fixes notmuch build errors during tests (segfaults) https://hydra.nixos.org/build/128029286/nixlog/1

T568-lib-thread: Testing API tests for notmuch_thread_*
 PASS   building database
 FAIL   get thread-id from closed database
        --- T568-lib-thread.2.EXPECTED  2020-10-01 20:31:15.076653846 +0000
        +++ T568-lib-thread.2.OUTPUT    2020-10-01 20:31:15.078653857 +0000
        @@ -1,4 +1,2 @@
         == stdout ==
        -1
        -0000000000000009
         == stderr ==
In file included from /nix/store/4wy9j24psf9ny4di3anjs7yk2fvfb0gq-glibc-2.31-dev/include/bits/libc-header-start.h:33,
                 from /nix/store/4wy9j24psf9ny4di3anjs7yk2fvfb0gq-glibc-2.31-dev/include/stdio.h:27,
                 from test1.c:1:
/nix/store/4wy9j24psf9ny4di3anjs7yk2fvfb0gq-glibc-2.31-dev/include/features.h:397:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
  397 | #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
      |    ^~~~~~~
/build/notmuch-1c80020/test/test-lib.sh: line 1094: 17263 Segmentation fault      (core dumped) ./${exec_file} "$@" >> OUTPUT.stdout 2>> OUTPUT.stderr
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from puckipedia and flokli October 6, 2020 09:34
@avdv
Copy link
Member Author

avdv commented Oct 6, 2020

Result of nixpkgs-review pr 99712 1

16 packages built:
  • aerc
  • afew
  • alot (python38Packages.alot)
  • astroid
  • haskellPackages.notmuch
  • lieer
  • meli
  • muchsync
  • neomutt
  • notmuch
  • notmuch-addrlookup
  • notmuch-mutt
  • python27Packages.notmuch
  • python37Packages.alot
  • python37Packages.notmuch
  • python38Packages.notmuch

@risicle
Copy link
Contributor

risicle commented Oct 6, 2020

Builds happily, macos 10.14

@gebner gebner merged commit 02a318d into NixOS:master Oct 8, 2020
@gebner
Copy link
Member

gebner commented Oct 8, 2020

Backported as 31cf6ac

@avdv avdv deleted the notmuch-0.31 branch October 8, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

@puckipedia puckipedia Awaiting requested review from puckipedia

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@avdv @risicle @gebner @chvp