Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/plasma5: add spectacle default #99693

Merged
merged 1 commit into from Oct 6, 2020
Merged

nixos/plasma5: add spectacle default #99693

merged 1 commit into from Oct 6, 2020

Conversation

worldofpeace
Copy link
Contributor

Fixes #99680.

In the future I think it would be nice if plasma5 could assume
an approach for an interface we have in the gnome3 module 0.
Notably being able to exclude packages with an option from
the default environment and having a default environment that
is useful to the average user. See 1, currently plasma5 defaults
are very "hard core hacker" with the most bare bones setup.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
nixos/plasma5: add spectacle default
55bc3e4 
Fixes NixOS#99680.

In the future I think it would be nice if plasma5 could assume
an approach for an interface we have in the gnome3 module [0].
Notably being able to exclude packages with an option from
the default environment and having a default environment that
is useful to the average user. See [1], currently plasma5 defaults
are very "hard core hacker" with the most bare bones setup.

[0]: NixOS#67310
[1]: NixOS#67310 (comment)
@worldofpeace
Copy link
Contributor Author

@ofborg test plasma5

@worldofpeace
Copy link
Contributor Author

This needs some sort of release note, I think.

@KamilaBorowska KamilaBorowska mentioned this pull request Oct 6, 2020
Closed
KamilaBorowska
KamilaBorowska approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@KamilaBorowska KamilaBorowska left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of including Spectacle by default, most KDE users will probably want to have it installed, and I think it would be useful to have on Live CD.

@adisbladis
Copy link
Member

adisbladis commented Oct 6, 2020 •
edited

This needs some sort of release note, I think.

I don't think it does, it's a really minor edit. But we should add backports to relevant channels.

@adisbladis adisbladis merged commit f26d663 into NixOS:master Oct 6, 2020
@worldofpeace worldofpeace deleted the spectacle-in-plasma5-default branch October 6, 2020 20:27
@worldofpeace
Copy link
Contributor Author

backported to 20.09 ad10d15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamilaBorowska KamilaBorowska KamilaBorowska approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: qt/kde 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to create screenshots in KDE
3 participants
@worldofpeace @adisbladis @KamilaBorowska