@endgame This is a backport. That means you really can't request changes to already committed code without encouraging diversion which has to be forward ported.

@worldofpeace Fair enough then.

@endgame Not sure if you could submit a review the original merged PR, though. Let's see what @andir thinks

I tried to build firefox from nixpkgs master without wayland and it broke because it couldn't find -lpipewire so something needs to be reported: either on the original PR or as a new issue. No point pretending that wayland is an option if it breaks when turned off.

Thank you for testing and reporting @endgame.

@worldofpeace due to the quality of the patch I didn't want it in the first place but was probably too inactive to make my opinion voiced enough. At this stage I'd at least refrain from adding it to the stable release. It is a nice feature and a pity but I do not see us having the manpower to do fix and support this patch.

I'll spend a bit of time trying to clean the patch up to fix the situation in both master and this backport. If that fails I'm still in favor of skipping it or making the entire code optional (which is a mess I really dislike).

This patch is actually being used in more distros than I thought, see https://github.com/emersion/xdg-desktop-portal-wlr/wiki/Screencast-Compatibility#webrtc-aka-firefoxchromium

This patch is actually being used in more distros than I thought, see https://github.com/emersion/xdg-desktop-portal-wlr/wiki/Screencast-Compatibility#webrtc-aka-firefoxchromium

Yeah but most of them hide it behind a feature flag and/or only provide a single build for their entire distribution. Here we are trying to allow users to customize the package but didn't bake that into the expression when this patch was added.

I just pushed c9c0b90 to this branch which does the required housekeeping for the added patch. I'll also add this to unstable once we agree on it.

This patch is actually being used in more distros than I thought, see https://github.com/emersion/xdg-desktop-portal-wlr/wiki/Screencast-Compatibility#webrtc-aka-firefoxchromium

Yeah but most of them hide it behind a feature flag and/or only provide a single build for their entire distribution. Here we are trying to allow users to customize the package but didn't bake that into the expression when this patch was added.

I just pushed c9c0b90 to this branch which does the required housekeeping for the added patch. I'll also add this to unstable once we agree on it.

Thanks, it looks good.

@andir Could you also summarize your current stance on this? It seems you've taken a few and it's not clearly linear because some of it is in the review comments.

This PR as is is probably fine. If you want to carry that into a release that sounds fine. I still worry about keeping the feature stable as we effectively now depend on Mozilla and a single fedora maintainer. Given the history with pipewire fedora will probably continue to provide patches. I just hope they'll do it on time as very often they were slower than us in updating the browser when security issues appeared.