Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.python-csxcad: init at unstable-2020-02-18 #99695

Merged
merged 1 commit into from Oct 6, 2020
Merged

pythonPackages.python-csxcad: init at unstable-2020-02-18 #99695

merged 1 commit into from Oct 6, 2020

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Oct 6, 2020 •
edited

Motivation for this change

Adds python bindings for CSXCAD. @jonringer this is the 2nd last PR related to this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthuszagh
Copy link
Contributor Author

Done, @jonringer.

jonringer
jonringer approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99695 1

3 packages built:
  • python27Packages.python-csxcad
  • python37Packages.python-csxcad
  • python38Packages.python-csxcad

@jonringer jonringer merged commit b0a8a17 into NixOS:master Oct 6, 2020
@matthuszagh matthuszagh deleted the python-csxcad branch October 6, 2020 17:23
@matthuszagh matthuszagh mentioned this pull request Oct 13, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthuszagh @jonringer