mirage: 0.5.2 -> 0.6.4 #99121

vojta001 · 2020-09-29T22:15:05Z

Motivation for this change

Things done

vojta001 · 2020-09-29T22:15:40Z

vojta001 · 2020-09-30T08:56:59Z

The only problematic part is QML cache. Mirage stores its QML caches in .cache/mirage/mirage/qmlcache, however it is not purged on update, causing problems. I suspect it is related to the fact the mirage binary in the Nix store has the creation timestamp 0 (as all files in the store). Can we do anything about it?

symphorien · 2020-10-22T18:42:44Z

Works after clearing the cache

colemickens · 2020-10-28T00:59:49Z

We could write a wrapper that writes "last-booted-version" to a file in cache near (in?) mirage's dir. If we see it's different on next boot, we wipe the mirage cache dir before starting?

symphorien · 2020-10-29T08:51:36Z

Or maybe we can patch the path to the cache to be .cache/mirage/$out ? Is there a XDG_SOMETHING_DIR variable that we can set in the wrapper ?

mirukana · 2020-11-12T17:46:19Z

There are some environment variable to disable or relocate the cache: https://doc.qt.io/qt-5/qmldiskcache.html

symphorien · 2020-11-12T19:13:43Z

Thanks !
This diff solves the segfault:

diff --git a/pkgs/applications/networking/instant-messengers/mirage/default.nix b/pkgs/applications/networking/instant-messengers/mirage/default.nix
index de84f3a0405..c204ca720e3 100644
--- a/pkgs/applications/networking/instant-messengers/mirage/default.nix
+++ b/pkgs/applications/networking/instant-messengers/mirage/default.nix
@@ -45,6 +45,7 @@ mkDerivation rec {
     buildPythonPath "$out $pythonPath"
     wrapProgram $out/bin/mirage \
       --prefix PYTHONPATH : "$PYTHONPATH" \
+      --run 'export QML_DISK_CACHE_PATH=''${XDG_CACHE_HOME:-$HOME/.cache}/mirage/qmlcache/${placeholder "out"}' \
       "''${qtWrapperArgs[@]}"
     '';

mirukana · 2020-11-13T20:53:03Z

Try also mirukana/mirage#90 (comment), if this causes no issues we can use the flag by default for future releases.

symphorien · 2020-11-14T08:16:02Z

Indeed with

diff --git a/pkgs/applications/networking/instant-messengers/mirage/default.nix b/pkgs/applications/networking/instant-messengers/mirage/default.nix
index de84f3a0405..c57e57d5d75 100644
--- a/pkgs/applications/networking/instant-messengers/mirage/default.nix
+++ b/pkgs/applications/networking/instant-messengers/mirage/default.nix
@@ -38,7 +38,7 @@ mkDerivation rec {
 
   pythonPath = pypkgs;
 
-  qmakeFlags = [ "PREFIX=${placeholder "out"}" ];
+  qmakeFlags = [ "PREFIX=${placeholder "out"}" "CONFIG+=qtquickcompiler" ];
 
   dontWrapQtApps = true;
   postInstall = ''

I can alternate between stable's mirage and this PR without segfault.

SuperSandro2000 · 2020-11-24T00:21:00Z

@vojta001 Can you update your PR with the cache fixes?

vojta001 · 2020-11-24T12:57:53Z

@SuperSandro2000 And what solution do we prefer? Is it disabling the cache completely (probably slower, but does not fill the home dir with mess), or adding the derivation hash to the cache name?

symphorien · 2020-11-24T13:10:28Z

My preference goes to #99121 (comment)

vojta001 · 2020-11-25T13:39:36Z

Here you go. Please review @colemickens

SuperSandro2000 · 2020-11-26T00:51:53Z

Result of nixpkgs-review pr 99121 run on x86_64-linux 1

1 package built:

mirage-im

SuperSandro2000 · 2020-11-26T00:53:30Z

on darwin:

clarative-5.12.7/lib/libQt5Qml.dylib /nix/store/qafg270zx0ih7rr18gxfvx0b8jb2dnfw-qtbase-5.12.7/lib/libQt5Network.dylib /nix/store/qafg270zx0ih7rr18gxfvx0b8jb2dnfw-qtbase-5.12.7/lib/libQt5Core.dylib -framework OpenGL -framework AGL
@nix { "action": "setPhase", "phase": "glibPreInstallPhase" }
glibPreInstallPhase
@nix { "action": "setPhase", "phase": "installPhase" }
installing
install flags: SHELL=/nix/store/k89nm2jva0qmvd970f84wq2iq1iwm9bs-bash-4.4-p23/bin/bash gsettingsschemadir=/nix/store/dkrwri1an9582pmpbz8c4250qdkzcmgc-mirage-0.5.2/share/gsettings-schemas/mirage-0.5.2/glib-2.0/schemas/ install
Makefile:835: warning: overriding recipe for target 'install_icons256'
Makefile:817: warning: ignoring old recipe for target 'install_icons256'
Makefile:839: warning: overriding recipe for target 'uninstall_icons256'
Makefile:821: warning: ignoring old recipe for target 'uninstall_icons256'
/nix/store/gzxz5xbx5bcvy5lvh8g9wv0871ipi9na-qtbase-5.12.7-dev/bin/qmake -install qinstall /private/tmp/nix-build-mirage-0.5.2.drv-0/source/extra/linux/mirage.png /nix/store/dkrwri1an9582pmpbz8c4250qdkzcmgc-mirage-0.5.2/share/icons/hicolor/256x256/apps/mirage.png
/nix/store/gzxz5xbx5bcvy5lvh8g9wv0871ipi9na-qtbase-5.12.7-dev/bin/qmake -install qinstall /private/tmp/nix-build-mirage-0.5.2.drv-0/source/extra/linux/mirage.desktop /nix/store/dkrwri1an9582pmpbz8c4250qdkzcmgc-mirage-0.5.2/share/applications/mirage.desktop

Builder called die: Cannot wrap '/nix/store/dkrwri1an9582pmpbz8c4250qdkzcmgc-mirage-0.5.2/bin/mirage' because it is not an executable file
Backtrace:
7 assertExecutable /nix/store/g5nqhchcnq9c9ym8ihqj8v5mbbibsa3x-hook/nix-support/setup-hook
136 wrapProgram /nix/store/g5nqhchcnq9c9ym8ihqj8v5mbbibsa3x-hook/nix-support/setup-hook
90 _callImplicitHook /nix/store/m40i7gdarksan1ax23vvwrq17p3pxjb3-stdenv-darwin/setup
106 _eval /nix/store/m40i7gdarksan1ax23vvwrq17p3pxjb3-stdenv-darwin/setup
49 runHook /nix/store/m40i7gdarksan1ax23vvwrq17p3pxjb3-stdenv-darwin/setup
1118 installPhase /nix/store/m40i7gdarksan1ax23vvwrq17p3pxjb3-stdenv-darwin/setup
1309 genericBuild /nix/store/m40i7gdarksan1ax23vvwrq17p3pxjb3-stdenv-darwin/setup
2 main /nix/store/9krlzvny65gdc8s7kpb6lkx8cd02c25b-default-builder.sh

vojta001 · 2020-11-30T12:40:46Z

@SuperSandro2000 What do you suggest? Adding the qtquickcompiler for Linux only?

symphorien · 2020-12-01T13:56:39Z

Mirage has never built on darwin so let's remove darwin from meta.platforms.

https://hydra.nixos.org/job/nixpkgs/trunk/mirage-im.x86_64-darwin/all

SuperSandro2000 · 2020-12-01T18:15:17Z

Either mark it broken if upstream has darwin support. If upstream does not mention support for darwin remove it from platforms.

vojta001 · 2020-12-08T22:58:57Z

@SuperSandro2000 Done. Their support of Darwin isn't the best, but they claim it to be doable and there are unofficial guides for building on Darwin

SuperSandro2000 · 2020-12-09T03:42:12Z

Result of nixpkgs-review pr 99121 run on x86_64-linux 1

1 package built:

mirage-im

SuperSandro2000 · 2020-12-09T03:42:16Z

Result of nixpkgs-review pr 99121 run on x86_64-darwin 1

1 package marked as broken and skipped:

mirage-im

pkgs/applications/networking/instant-messengers/mirage/default.nix

symphorien · 2020-12-10T20:05:53Z

can you solve the merge conflict ?

vojta001 · 2020-12-11T11:39:48Z

Shall I merge master into my feature branch or shall I rebase onto master?

symphorien · 2020-12-11T19:51:03Z

please rebase. You may find it easier if you squash your commits before rebasing.

vojta001 · 2020-12-13T08:36:25Z

Done

vojta001 · 2020-12-13T15:43:46Z

Could you please test the resulting binary? I have problems with it now and I don't know whether they are related to the state of my .cache folder or whether the build is broken.

symphorien · 2020-12-14T07:24:15Z

works for me. How does it fail on your end?

vojta001 · 2020-12-14T22:03:24Z

The windows launches (therefore QML cache works just fine) and displays

Unexpected error occured: OlmAccountError

load_saved_accounts.<some uid>

Traceback (most recent call last):
  File "qrc:/src/backend/qml_bridge.py", line 83, in on_done
    result = future.result()
  File "/nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/python3.8/concurrent/futures/_base.py", line 432, in result
    return self.__get_result()
  File "/nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/python3.8/concurrent/futures/_base.py", line 388, in __get_result
    raise self._exception
  File "qrc:/src/backend/backend.py", line 295, in load_saved_accounts
    return await asyncio.gather(*(
  File "qrc:/src/backend/backend.py", line 284, in resume
    await self.resume_client(
  File "qrc:/src/backend/backend.py", line 272, in resume_client
    await client.resume(user_id, token, device_id, state, status_msg)
  File "qrc:/src/backend/matrix_client.py", line 311, in resume
    self.restore_login(user_id, device_id, access_token)
  File "/nix/store/qssk7fsipsl6chwfr3kn9fcx9yp0pr7d-python3.8-matrix-nio-0.15.1/lib/python3.8/site-packages/nio/client/base_client.py", line 406, in restore_login
    self.load_store()
  File "/nix/store/qssk7fsipsl6chwfr3kn9fcx9yp0pr7d-python3.8-matrix-nio-0.15.1/lib/python3.8/site-packages/nio/client/base_client.py", line 382, in load_store
    self.olm = Olm(self.user_id, self.device_id, self.store)
  File "/nix/store/qssk7fsipsl6chwfr3kn9fcx9yp0pr7d-python3.8-matrix-nio-0.15.1/lib/python3.8/site-packages/nio/crypto/olm_machine.py", line 213, in __init__
    account = self.store.load_account()  # type: ignore
  File "/nix/store/qssk7fsipsl6chwfr3kn9fcx9yp0pr7d-python3.8-matrix-nio-0.15.1/lib/python3.8/site-packages/nio/store/database.py", line 166, in load_account
    return OlmAccount.from_pickle(
  File "/nix/store/qssk7fsipsl6chwfr3kn9fcx9yp0pr7d-python3.8-matrix-nio-0.15.1/lib/python3.8/site-packages/nio/crypto/sessions.py", line 45, in from_pickle
    account = super().from_pickle(pickle, passphrase)
  File "/nix/store/bxipga1mp2s3vgclma5linvjyn0ailwf-python3.8-python-olm-3.1.5/lib/python3.8/site-packages/olm/account.py", line 166, in from_pickle
    obj._check_error(ret)
  File "/nix/store/bxipga1mp2s3vgclma5linvjyn0ailwf-python3.8-python-olm-3.1.5/lib/python3.8/site-packages/olm/account.py", line 99, in _check_error
    raise OlmAccountError(last_error)
olm.account.OlmAccountError: UNKNOWN_PICKLE_VERSION

symphorien · 2020-12-15T19:46:28Z

Wild guess: did you run a version of mirage using a later version of python which has introduced a new version of the pickle format?
@mirukana any idea of the cause?

vojta001 · 2020-12-15T21:35:27Z

It is possible. I have compiled and run multiple variants during the development of this PR. Interestingly the current v0.5.2 works fine for me.

If the problem is on my machine only, let's just proceed and I'll simply wipe my .cache/mirage folder.

symphorien · 2020-12-20T19:18:40Z

@GrahamcOfBorg build mirage-im

ofborg bot requested a review from colemickens September 29, 2020 22:25

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 29, 2020

SuperSandro2000 requested changes Dec 9, 2020

View reviewed changes

pkgs/applications/networking/instant-messengers/mirage/default.nix Outdated Show resolved Hide resolved

pkgs/applications/networking/instant-messengers/mirage/default.nix Outdated Show resolved Hide resolved

ofborg bot added the 2.status: merge conflict label Dec 9, 2020

vojta001 added 4 commits December 13, 2020 09:34

mirage: 0.5.2 -> 0.6.4

191f7fa

mirage: Use qtquickcompiler to prevent QML cache problems

9fad7ec

mirage: Mark it as broken on Darwin

00333e4

mirage: refactor

8ca98c7

vojta001 force-pushed the mirage branch from 1c41dfd to 8ca98c7 Compare December 13, 2020 08:35

ofborg bot removed the 2.status: merge conflict label Dec 13, 2020

symphorien merged commit fbefb7e into NixOS:master Dec 20, 2020

vojta001 deleted the mirage branch December 20, 2020 19:40

symphorien mentioned this pull request Jan 20, 2021

Avatars and usernames not displayed Nheko-Reborn/nheko#389

Closed

symphorien mentioned this pull request Jun 15, 2022

Qt/KDE applications segfault on start due to stale qmlcache #177720

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mirage: 0.5.2 -> 0.6.4 #99121

mirage: 0.5.2 -> 0.6.4 #99121

vojta001 commented Sep 29, 2020 •

edited

vojta001 commented Sep 29, 2020

vojta001 commented Sep 30, 2020

symphorien commented Oct 22, 2020

colemickens commented Oct 28, 2020

symphorien commented Oct 29, 2020

mirukana commented Nov 12, 2020

symphorien commented Nov 12, 2020

mirukana commented Nov 13, 2020

symphorien commented Nov 14, 2020

SuperSandro2000 commented Nov 24, 2020

vojta001 commented Nov 24, 2020

symphorien commented Nov 24, 2020

vojta001 commented Nov 25, 2020

SuperSandro2000 commented Nov 26, 2020

SuperSandro2000 commented Nov 26, 2020

vojta001 commented Nov 30, 2020

symphorien commented Dec 1, 2020

SuperSandro2000 commented Dec 1, 2020

vojta001 commented Dec 8, 2020

SuperSandro2000 commented Dec 9, 2020

SuperSandro2000 commented Dec 9, 2020

symphorien commented Dec 10, 2020

vojta001 commented Dec 11, 2020

symphorien commented Dec 11, 2020

vojta001 commented Dec 13, 2020

vojta001 commented Dec 13, 2020

symphorien commented Dec 14, 2020

vojta001 commented Dec 14, 2020

symphorien commented Dec 15, 2020

vojta001 commented Dec 15, 2020

symphorien commented Dec 20, 2020

mirage: 0.5.2 -> 0.6.4 #99121

mirage: 0.5.2 -> 0.6.4 #99121

Conversation

vojta001 commented Sep 29, 2020 • edited

Motivation for this change

Things done

vojta001 commented Sep 29, 2020

vojta001 commented Sep 30, 2020

symphorien commented Oct 22, 2020

colemickens commented Oct 28, 2020

symphorien commented Oct 29, 2020

mirukana commented Nov 12, 2020

symphorien commented Nov 12, 2020

mirukana commented Nov 13, 2020

symphorien commented Nov 14, 2020

SuperSandro2000 commented Nov 24, 2020

vojta001 commented Nov 24, 2020

symphorien commented Nov 24, 2020

vojta001 commented Nov 25, 2020

SuperSandro2000 commented Nov 26, 2020

SuperSandro2000 commented Nov 26, 2020

vojta001 commented Nov 30, 2020

symphorien commented Dec 1, 2020

SuperSandro2000 commented Dec 1, 2020

vojta001 commented Dec 8, 2020

SuperSandro2000 commented Dec 9, 2020

SuperSandro2000 commented Dec 9, 2020

symphorien commented Dec 10, 2020

vojta001 commented Dec 11, 2020

symphorien commented Dec 11, 2020

vojta001 commented Dec 13, 2020

vojta001 commented Dec 13, 2020

symphorien commented Dec 14, 2020

vojta001 commented Dec 14, 2020

symphorien commented Dec 15, 2020

vojta001 commented Dec 15, 2020

symphorien commented Dec 20, 2020

vojta001 commented Sep 29, 2020 •

edited