New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bottom: init at 0.4.7 #99126
bottom: init at 0.4.7 #99126
Conversation
ccing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for me on non-NixOS linux.
Needs IOKit to compile on macOS, and the resulting executable just shows empty graphs. Is that a bug, or is this linux-only?
pkgs/tools/system/bottom/default.nix
Outdated
@@ -0,0 +1,26 @@ | |||
{ stdenv, fetchFromGitHub, rustPlatform }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ stdenv, fetchFromGitHub, rustPlatform }: | |
{ stdenv, fetchFromGitHub, rustPlatform, darwin }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed!
}; | ||
|
||
cargoSha256 = "XeX6QM0a628mcaptNZkKAvDnGfW5tx+aWNBpMyjz44M="; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildInputs = stdenv.lib.optional stdenv.hostPlatform.isDarwin darwin.apple_sdk.frameworks.IOKit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed!
Co-authored-by: r-burns <52847440+r-burns@users.noreply.github.com>
I tried building this on a Darwin machine but I had SSL certificate errors when fetching dependencies with Cargo so I'll leave the testing to @r-burns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for taking care of that, compiles + runs for me now. I see that bottom claims to support macOS so I've filed an issue upstream. As for this PR, LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation for this change
bottom is "a cross-platform graphical process/system monitor with a customizable interface and a multitude of features".
ytop has been archived by its owner.
bottom
has been recommended byytop
's creator.Some tests are failing because they call the binary and it tries to create its default file in
$XDG_CONFIG_HOME/bottom/bottom.toml
.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)