Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delly: 0.8.2 -> 0.8.5 #99128

Merged
merged 1 commit into from Oct 16, 2020
Merged

delly: 0.8.2 -> 0.8.5 #99128

merged 1 commit into from Oct 16, 2020

Conversation

jbedo
Copy link
Contributor

@jbedo jbedo commented Sep 29, 2020 •
edited

Motivation for this change

New release of delly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jbedo
Copy link
Contributor Author

jbedo commented Sep 29, 2020

@scalavision

@scalavision
Copy link
Contributor

scalavision commented Sep 30, 2020 •
edited

I run through a whole genome bam file, it resulted in 30k+ lines of vcf file. I will benchmark against gold standard tomorrow, I think however, that this can be merged after the license has been updated. Thanks a lot for providing this update!

scalavision
scalavision suggested changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@scalavision scalavision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the license has changed from gpl3 to bsd2, @jbedo , could you update this as well?

dellytools/delly@06f0b0c#diff-04c6e90faac2675aa89e2176d2eec7d8R12

@jbedo
Copy link
Contributor Author

jbedo commented Sep 30, 2020

Oops, completely missed the license change!

scalavision
scalavision suggested changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@scalavision scalavision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... I think it is actually BSD3 isn't it, not mit? If you can change to bsd3 it would be nice :-)

@jbedo
Copy link
Contributor Author

jbedo commented Oct 1, 2020

Hm... I think it is actually BSD3 isn't it, not mit? If you can change to bsd3 it would be nice :-)

Not sure how I got that wrong, I meant to write bsd3.

scalavision
scalavision approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@scalavision scalavision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks :-)

@scalavision
Copy link
Contributor

@ryantm could you have a look at this one? As far as I can tell everything is ok. I have also tested running the tool locally.

@ryantm
Copy link
Member

ryantm commented Oct 16, 2020

Result of nixpkgs-review pr 99128 1

1 package built:
- delly

@ryantm ryantm merged commit f9728ad into NixOS:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scalavision scalavision scalavision approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbedo @scalavision @ryantm