Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebHID] Change some interfaces to dictionaries #25863

Merged
merged 1 commit into from Oct 1, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 30, 2020

This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: WICG/webhid#22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398541
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#812626}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This CL changes HIDCollectionInfo, HIDReportInfo, and HIDReportItem
interfaces to dictionaries for easier logging with JSON and to avoid
polluting the window web namespace.

Spec: WICG/webhid#22
Test: https://webhid-collections.glitch.me/

Change-Id: Ife8d089505312bba9f42e5d8fb1c466f44bd8e45
Bug: 890096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398541
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#812626}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants