Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] pythonPackages.ruffus: 2.8.1 -> 2.8.4, fix build #99111

Merged
merged 1 commit into from Sep 29, 2020
Merged

[20.09] pythonPackages.ruffus: 2.8.1 -> 2.8.4, fix build #99111

merged 1 commit into from Sep 29, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 29, 2020 •
edited

Motivation for this change

ZHF: #97479

Backport of #98814

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
pythonPackages.ruffus: 2.8.1 -> 2.8.4, fix build
e97060a 
simplify test execution by skipping their makefile entirely. disable tests
on darwin as they are very flaky & hang often. this is probably ok because
we're not hacking this package's source to get it installed, and the user
is probably getting something very similar as they would get using a
regular pip installation.

(cherry picked from commit 85e6474)
@risicle risicle changed the title pythonPackages.ruffus: 2.8.1 -> 2.8.4, fix build [20.09] pythonPackages.ruffus: 2.8.1 -> 2.8.4, fix build Sep 29, 2020
@ofborg ofborg bot requested a review from Kiwi September 29, 2020 20:05
jonringer
jonringer approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99111 1

3 packages built:
  • python27Packages.ruffus
  • python37Packages.ruffus
  • python38Packages.ruffus

@jonringer jonringer merged commit 46e16fe into NixOS:release-20.09 Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@Kiwi Kiwi Awaiting requested review from Kiwi

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer