Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencv: allow other blas/lapack #99129

Closed
wants to merge 1 commit into from
Closed

Conversation

tbenst
Copy link
Contributor

@tbenst tbenst commented Sep 30, 2020

Motivation for this change

I believe this assert statement was added 5 years ago by @bjornfor. It is no longer necessary as MKL passes tests just fine

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This targets the release branch, but is not a cherry pick. Otherwise looks fine to me.

@tbenst
Copy link
Contributor Author

tbenst commented Sep 30, 2020

@bjornfor I fixed on release branch and cherry-picked to master...is that an issue?

@bjornfor
Copy link
Contributor

It's preferred to fix things on master and then cherry pick to the release branch(es).

Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This targets tje release branch, but is not a cherry pick. Otherwise looks fine to me.

@FRidh
Copy link
Member

FRidh commented Nov 21, 2020

pushed to master in 39acab6

@FRidh FRidh closed this Nov 21, 2020
@FRidh
Copy link
Member

FRidh commented Nov 21, 2020

20.09 in 9da0758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants