Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] kdeApplications: expose missing packages, fix hydra #99139

Merged
merged 1 commit into from Sep 30, 2020
Merged

[20.09] kdeApplications: expose missing packages, fix hydra #99139

merged 1 commit into from Sep 30, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 30, 2020 •
edited

Motivation for this change

fixes nixosTests.plasma5
fixes #98657 (comment)

fixes broken hydra eval https://hydra.nixos.org/jobset/nixos/release-20.09#tabs-errors

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer changed the title [20.09] kdeApplications: expose missing packages [20.09] kdeApplications: expose missing packages, fix hydra Sep 30, 2020
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg test plasma5

@jonringer
Copy link
Contributor Author

doing nix-shell -p hydra-unstable --run 'hydra-eval-jobs -I . nixos/release.nix' seems to be doing a normal hydra eval now, instead of immediately failing

@jonringer
Copy link
Contributor Author

plasma5 test passed, merging

20.09 was the only branch affected.

@jonringer jonringer merged commit f340be7 into NixOS:release-20.09 Sep 30, 2020
@jonringer jonringer deleted the 20.09-fix-plasma-hydra branch September 30, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer