Fix docs regression, and removes workarounds #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"default" values in Nixpkgs manual can *somehow* be escaped by the
documentation back to their original string form.
The following ends up escaped into the manual as `"${pkgs.hello}"`.
```
default = "${pkgs.hello}";
```
The methods for this magic have not been found.
Instead, we just change the default strict `handleEvalIssue` so that it
does absolutely nothing and lets them through.
Anyway we won't be building them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation could get stuck building from under our feet at any point a new option used the following form when defining an option default value.
"default" values in Nixpkgs manual can somehow be escaped by the
documentation back to their original string form.
The following ends up escaped into the manual as
"${pkgs.hello}".The methods for this magic have not been found.
Instead, we just change the default strict
handleEvalIssueso that itdoes absolutely nothing and lets them through.
Anyway we won't be building them.