[Gecko Bug 1660122] Part 7 - Implement GetAspectRatio(). #25860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves the preferred aspect-ratio calculation from each replaced elements' GetIntrinicRatio() into GetAspectRatio(), because they share the same logic. For nsImageFrame, the cached mIntrinsicRatio now stores only the image's intrinsic ratio, not considering the aspect-ratio property. This patch fixed "object-fit:contain" for canvas, image because GetIntrinicRatio() no longer considers aspect-ratio. This also fixed replaced elements' size when both "aspect-ratio:<ratio>" and "contain:size" is specified. This also makes us pass some of the aspect-ratio tests because we change GetIntrinicRatio() into GetAspectRatio() in nsLayoutUtils::IntrinsicForAxis() in Part5, which is used by nsBlockFrame (via nsLayoutUtils::IntrinsicForContainer) to implement GetMinISize(). Differential Revision: https://phabricator.services.mozilla.com/D91229 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1660122 gecko-commit: a81a1a6e1c0fe190fa844906c10234a2238919fb gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the preferred aspect-ratio calculation from each
replaced elements' GetIntrinicRatio() into GetAspectRatio(), because
they share the same logic.
For nsImageFrame, the cached mIntrinsicRatio now stores only the image's
intrinsic ratio, not considering the aspect-ratio property.
This patch fixed "object-fit:contain" for canvas, image because
GetIntrinicRatio() no longer considers aspect-ratio. This also fixed
replaced elements' size when both "aspect-ratio:" and
"contain:size" is specified.
This also makes us pass some of the aspect-ratio tests because we change
GetIntrinicRatio() into GetAspectRatio() in
nsLayoutUtils::IntrinsicForAxis() in Part5, which is used by nsBlockFrame
(via nsLayoutUtils::IntrinsicForContainer) to implement GetMinISize().
Differential Revision: https://phabricator.services.mozilla.com/D91229
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1660122
gecko-commit: a81a1a6e1c0fe190fa844906c10234a2238919fb
gecko-reviewers: emilio