Move the default framebuffer scale off of VRDisplayInfo #25862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 30, 2020
This value does not change over the lifetime of a session, and does not need to be communicated with the same frequency as other VRDisplayInfo attributes. Sending it once at the start of a session better matches how the value is used in practice. Bug: 1017477 Change-Id: I09e1507418c6dfbab3d19b0d909b6f4753a6d4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438452 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#812278}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2438452
branch
from
8f6f8eb
to
37db954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value does not change over the lifetime of a session, and does not
need to be communicated with the same frequency as other VRDisplayInfo
attributes. Sending it once at the start of a session better matches how
the value is used in practice.
Bug: 1017477
Change-Id: I09e1507418c6dfbab3d19b0d909b6f4753a6d4c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438452
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812278}