Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precice: fix build, 2.0.2 -> 2.1.0, enable for darwin #99118

Merged
merged 3 commits into from Sep 30, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 29, 2020

Motivation for this change

ZHF: #97479

This broke when python3 was switched to 3.8: cmake gets confused with python 3.8's version number. Switch back to 3.7 for now until upstream's resolved that.

Bump to 2.1.0 while we're at it and enable for darwin because it builds for me macos 10.14

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cmake gets confused with python 3.8's version number, switch back to 3.7
for now until upstream's resolved that
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nixpkgs-review on macos 10.14, non-NixOS Linux

Copy link
Contributor

@Scriptkiddi Scriptkiddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@risicle risicle merged commit 701a6aa into NixOS:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants