Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scs: 2.1.1 -> 2.1.2 #96613

Closed
wants to merge 1 commit into from
Closed

scs: 2.1.1 -> 2.1.2 #96613

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/scs/versions.

meta.description for scs is: "Splitting Conic Solver"

meta.homepage for scs is: "https://github.com/cvxgrp/scs"

meta.changelog for scs is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
56 total rebuild path(s)

16 package rebuild(s)

16 x86_64-linux rebuild(s)
8 i686-linux rebuild(s)
16 x86_64-darwin rebuild(s)
16 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
python27Packages.scs
python37Packages.cvxpy
python37Packages.qasm2image
python37Packages.qiskit
python37Packages.qiskit-aer
python37Packages.qiskit-aqua
python37Packages.qiskit-ignis
python37Packages.scs
python38Packages.cvxpy
python38Packages.qasm2image
python38Packages.qiskit
python38Packages.qiskit-aer
python38Packages.qiskit-aqua
python38Packages.qiskit-ignis
python38Packages.scs
scs
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/4iawdsmlnjdml5lfxd9gwnqym828ackp-scs-2.1.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A scs https://github.com/r-ryantm/nixpkgs/archive/46699093335867f43819410a646ec4df87b01163.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/4iawdsmlnjdml5lfxd9gwnqym828ackp-scs-2.1.2
ls -la /nix/store/4iawdsmlnjdml5lfxd9gwnqym828ackp-scs-2.1.2/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

15 packages failed to build:
  • python27Packages.scs
  • python37Packages.cvxpy
  • python37Packages.qasm2image
  • python37Packages.qiskit
  • python37Packages.qiskit-aer
  • python37Packages.qiskit-aqua
  • python37Packages.qiskit-ignis
  • python37Packages.scs
  • python38Packages.cvxpy
  • python38Packages.qasm2image
  • python38Packages.qiskit
  • python38Packages.qiskit-aer
  • python38Packages.qiskit-aqua
  • python38Packages.qiskit-ignis
  • python38Packages.scs
1 package built:
  • scs

Maintainer pings

cc @bhipple for testing.

Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of those failing pkgs build on master, so this is going to need some investigation.

@ofborg ofborg bot requested a review from bhipple August 29, 2020 15:46
@SuperSandro2000 SuperSandro2000 marked this pull request as draft January 20, 2021 23:08
@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@r-burns
Copy link
Contributor

r-burns commented Oct 10, 2021

Yes, scs needs to be updated in lockstep with its python package. The cvxpy package also seems to be tightly coupled.

scs v3.0 is out but cvxpy support is still WIP: phschiele/cvxpy#17. I will plan on doing a big bump to 3.x once the ecosystem is ready

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 10, 2021
@r-burns
Copy link
Contributor

r-burns commented Dec 6, 2021

This has already been addressed, by #146434

@r-burns r-burns closed this Dec 6, 2021
@r-ryantm r-ryantm deleted the auto-update/scs branch December 8, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants