home-assistant: 0.114.3 -> 0.114.4, also: samsungtv and ipp integration init/update #96570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test home-assistant |
mweinelt
changed the title
|
@GrahamcOfBorg test home-assistant |
jonringer
reviewed
Aug 28, 2020
Loosens dependency requirements and thus fixes build with bumped yarl version.
|
that's a big diff, but I think it's still an improvement |
|
@GrahamcOfBorg test home-assistant |
jonringer
approved these changes
Aug 30, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 96570 1
8 packages built:
- home-assistant
- python27Packages.samsungctl
- python37Packages.pyipp
- python37Packages.samsungctl
- python37Packages.samsungtvws
- python38Packages.pyipp
- python38Packages.samsungctl
- python38Packages.samsungtvws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A few updates and inits to the home-assistant ecosystem.
samsungtvintegration support https://www.home-assistant.io/integrations/samsungtv/parse_requirements.pyto also find packages that defineextra_requires, likesamsungctl[websocket], cc extras_require in python packages #62833pyippto fix dependency on bumped yarl (home-assistant: 0.114.3 -> 0.114.4, also: samsungtv and ipp integration init/update #96570)Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)