Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enlightenment.terminology: use absolute path to edje_cc #96558

Merged
merged 1 commit into from Sep 4, 2020
Merged

enlightenment.terminology: use absolute path to edje_cc #96558

merged 1 commit into from Sep 4, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Aug 28, 2020 •
edited

Motivation for this change

Indicate the absolute path to edje_cc instead of defaulting to the system one (assuming it can be found in $PATH).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
enlightenment.terminology: use absolute path to edje_cc
5fdb167 
Indicate the absolute path to 'edje_cc' instead of defaulting to the
system one.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/280

@romildo
Copy link
Contributor Author

romildo commented Sep 4, 2020

This is a very simple change. Using it for a week without problems.
Merging.

@romildo romildo merged commit 9dc1d6a into NixOS:master Sep 4, 2020
@romildo romildo deleted the fix.terminology branch September 4, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @nixos-discourse