Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enlightenment.efl: add needed libraries #96559

Merged
merged 1 commit into from Sep 4, 2020
Merged

enlightenment.efl: add needed libraries #96559

merged 1 commit into from Sep 4, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Aug 28, 2020 •
edited

Motivation for this change

Some libraries are linked at runtime by hand in code (they are dlopened) in EFL and their path need to be hard coded.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/281

@romildo
Copy link
Contributor Author

romildo commented Sep 4, 2020

This fix makes applications more stable. Terminology was crashing with some applications, like vim for instance.
Merging.

@romildo romildo merged commit 28d7bc1 into NixOS:master Sep 4, 2020
@romildo romildo deleted the fix.efl branch September 4, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @nixos-discourse