Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/unbound: add couple of options #96631

Closed
wants to merge 1 commit into from
Closed

nixos/unbound: add couple of options #96631

wants to merge 1 commit into from

Conversation

wahjava
Copy link
Contributor

@wahjava wahjava commented Aug 29, 2020

  • forwardOverTLS. To forward DNS queries over TLS
  • includeFile. To include configuration from other file
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wahjava
nixos/unbound: add couple of options
b87b425 
 * forwardOverTLS. To forward DNS queries over TLS
 * includeFile. To include configuration from other file
@aanderse aanderse requested a review from rissson August 30, 2020 00:30
rissson
rissson reviewed Sep 2, 2020
View reviewed changes
Copy link
Member

@rissson rissson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I like this very much, but I think it won't be of much use once #89572 is merged.

@wahjava
Copy link
Contributor Author

wahjava commented Sep 13, 2020

Hey! I like this very much, but I think it won't be of much use once #89572 is merged.

Sure, I'm able to transition my local configuration to #89572, and they seem to work fine. So, closing this pull request.

@wahjava wahjava closed this Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rissson rissson rissson left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wahjava @rissson