Attempt to fix escaping in CSP tests #25275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{{GET}} is automatically HTML-escaped (*not* URL-encoded) when used in
`.sub.html`. There is some insufficient workaround in this test suite
for things like < >. This PR attempts to properly decode HTML entities.
|
Reviewers, could you please suggest a better place (e.g. a single entry point) to make this change as you're more familiar with the tests? I made this PoC without fully understanding the structure of this test suite. |
|
cc @ziransun too |
|
ping @hillbrad @andypaicu |
|
I did a cursory scan of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{GET}} is automatically HTML-escaped (not URL-encoded) when used in
.sub.html. There is some insufficient workaround in this test suitefor things like < >. This PR attempts to properly decode HTML entities.
Note: this is most likely not complete (only covers the case in #25141 ).
There are so many uses of
{{GET}}in.sub.htmlin this suite that mightneed similar treatment, so we might want to do this in e.g.
originFrameShouldBeinstead.