python-keystoneclient: Init at 4.1.0 (+ all openstack dependencies) #96624

SCOTT-HAMILTON · 2020-08-29T17:39:11Z

Motivation for this change

Things done

SCOTT-HAMILTON · 2020-08-29T17:41:51Z

This probably won't built because of importlib-metadata < 1.7.0, waiting for ofborg to tell me.

catern

My comments on the first module all apply for all the modules.

You should split these modules up into individual commits; and also, don't capitalize "Init".

pkgs/development/python-modules/debtcollector/default.nix

pkgs/top-level/python-packages.nix

FRidh

One commit per package.

pkgs/development/python-modules/debtcollector/default.nix

jonringer · 2020-08-31T18:32:08Z

sorry, I sorted python-packages.nix please reabase on latest master and re-sort the entries please :)

SCOTT-HAMILTON · 2020-09-01T13:13:40Z

Took a bit of time but conflicts have been fixed for each commits.

SCOTT-HAMILTON · 2020-09-02T13:35:29Z

Currently working on configuring the tox test suites. Don't merge this now.

SCOTT-HAMILTON · 2020-09-02T13:48:46Z

And now I've got a problem :
oslo-config test requires olsotest.
oslotest requires stestr.
stestr requires subunit2sql.
subunit2sql requires oslo-config >= 4.0.0

What should I do ?
I could make an oslo-config-no-check, make subunit2sql require it and then the rest would follow up.

catern · 2020-09-02T14:00:46Z

You should file an issue upstream - ideally they can easily break the circular test dependency and make a new fixed release - that's been my experience before.

Pending that, you can just skip tests in oslo-config.

SCOTT-HAMILTON · 2020-09-03T10:01:22Z

Filed an issue https://bugs.launchpad.net/oslo.config/+bug/1893978. I'll remove oslo-config tests for the moment.

SCOTT-HAMILTON · 2020-09-03T13:11:50Z

I've resolved checkInputs for all packages until reaching one of the packages of the circular dependency issue. So for now none of them have doCheck = true for this reason. Merging can be done, I'll PR an update when openstack solves this issue.

jonringer · 2020-09-03T19:36:27Z

pkgs/development/python-modules/debtcollector/default.nix

+    sha256 = "0ab8ic9bk644i8134z044kpcf6pvawqf4rq4xgv1p11msbs82ybq";
+  };
+
+  patches = [ ./tox-pass-system-pythonpath.patch ];


tox overlaps with nix does, usually I just remove the tox.ini's before testing.

Thanks for that, it makes it really easier !

jonringer · 2020-09-03T19:36:42Z

pkgs/development/python-modules/keystoneauth1/default.nix

+  ];
+
+  # Circular dependencies on stestr, see https://bugs.launchpad.net/oslo.config/+bug/1893978
+  doCheck = false;


If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.

jonringer · 2020-09-03T19:37:50Z

pkgs/development/python-modules/os-service-types/default.nix

+let
+  pbr_5_5_0 = pbr.overrideAttrs (old: {
+    version = "5.5.0";
+    name = "pbr-5.5.0";
+    src = fetchPypi {
+      pname = "pbr";
+      version = "5.5.0";
+      sha256 = "1sl2w7zq33kzbh6im3lyl7jfwyddjkqmrx0y5b93v2n7a67xkgql";
+    };
+  });
+in


having different versions of a python module can subtley break other packages at runtime.

This is only allowed with very few exceptions. Please try to remove it (relax version bounds on the package which is doing the pinning"

jonringer · 2020-09-03T19:38:17Z

pkgs/development/python-modules/os-service-types/default.nix

+
+  checkPhase = ''
+    export UPPER_CONSTRAINTS_FILE="${upper-constraints}"
+    tox


I would remove tox, and just do the test suite

jonringer · 2020-09-03T19:38:23Z

pkgs/development/python-modules/os-service-types/default.nix

+  '';
+
+  # Circular dependencies on oslotest, see https://bugs.launchpad.net/oslo.config/+bug/1893978
+  doCheck = false;


If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.

jonringer · 2020-09-03T19:39:11Z

pkgs/development/python-modules/oslo-config/default.nix

+    doc8
+    fixtures
+    oslo-i18n
+    tox


I would just remove tox, and run the commands it was meant to run

jonringer · 2020-09-03T19:39:24Z

pkgs/development/python-modules/oslo-i18n/default.nix

+let
+  bandit_1_5_1 = bandit.overrideAttrs (old: {
+    version = "1.5.1";
+    name = "bandit-1.5.1";
+    src = fetchPypi {
+      pname = "bandit";
+      version = "1.5.1";
+      sha256 = "0k5sd4xgd6lp2ap1vd8nk5fabcdyw62cf9fmj791n7nyx77zl4wl";
+    };
+  });
+in


shouldn't be allowed, see above

jonringer · 2020-09-03T19:40:01Z

pkgs/development/python-modules/python-keystoneclient/default.nix

+let 
+  pyModuleDeps = [
+    keystoneauth1
+    oslo-config
+    oslo-i18n
+    oslo-serialization
+    pbr
+  ];
+in


please just move below

jonringer · 2020-09-03T19:40:16Z

pkgs/development/python-modules/python-keystoneclient/python-keystoneclient/default.nix

+let 
+  pyModuleDeps = [
+    keystoneauth1
+    oslo-config
+    oslo-i18n
+    oslo-serialization
+    pbr
+  ];
+in


please just put on propagatedBuildInputs

jonringer · 2020-09-03T19:41:04Z

pkgs/top-level/python-packages.nix

+  python-keystoneclient = disabledIf (!pythonOlder "3.8") (callPackage ../development/python-modules/python-keystoneclient { });
+


please move into expression:

disabled = pythonAtLeast "3.8";

SCOTT-HAMILTON · 2020-09-04T18:36:33Z

Currently working on your change requests, removed tox on oslo-config test suite but I now have another circular dependency graph ( a bit simpler this time) :
oslo-config test suite requires oslo-log
oslo-log requires oslo-config.
So I'm just checking import oslo_config for now.

FRidh · 2020-09-04T18:41:25Z

I don't think having these packages in Nixpkgs is a good idea. We've had them in the past, and they were problematic because of incompatible dependencies. As commented by @jonringer, the same applies to this PR.

Check e.g. git log oslo and git log keystoneclient.

FRidh · 2020-09-20T06:42:49Z

Note that if all you need is a cli, and not importable libraries, you could use a tool such as poetry2nix. (Not saying anything about including that in Nixpkgs here though.)

nixos-discourse · 2020-09-20T06:42:54Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/pull-request-etiquette-when-submitting-lots-of-packages-at-once/9065/2

SuperSandro2000 · 2021-01-18T13:33:46Z

@SCOTT-HAMILTON please fix the eval issue.

SCOTT-HAMILTON · 2021-02-22T21:47:10Z

I think that @FRidh is right when he says that keystonclient is better out of nixpkgs. I still didn't get any answer from the ubuntu devs anyway regarding the circular deps. So despite having struggled a bit for this, I think it's better to close this PR.

SCOTT-HAMILTON requested review from FRidh and jonringer as code owners August 29, 2020 17:39

SCOTT-HAMILTON mentioned this pull request Aug 29, 2020

python-keystoneclient #86387

Closed

SCOTT-HAMILTON force-pushed the python-keystoneclient branch from 8e55e49 to e5d9ab6 Compare August 29, 2020 18:58

catern suggested changes Aug 29, 2020

View reviewed changes

FRidh requested changes Aug 29, 2020

View reviewed changes

ofborg bot added 6.topic: python 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Aug 29, 2020

SCOTT-HAMILTON force-pushed the python-keystoneclient branch from e5d9ab6 to 5ea2e77 Compare August 31, 2020 13:10

catern suggested changes Aug 31, 2020

View reviewed changes

pkgs/development/python-modules/debtcollector/default.nix Outdated Show resolved Hide resolved

ofborg bot added 10.rebuild-linux: 0 and removed 10.rebuild-linux: 11-100 labels Sep 1, 2020

SCOTT-HAMILTON force-pushed the python-keystoneclient branch from fd14838 to 6d5524a Compare September 1, 2020 13:12

ofborg bot added 10.rebuild-linux: 11-100 and removed 10.rebuild-linux: 0 labels Sep 1, 2020

SCOTT-HAMILTON force-pushed the python-keystoneclient branch from 6d5524a to 6b06d7e Compare September 3, 2020 12:33

SCOTT-HAMILTON requested a review from mmahut as a code owner September 3, 2020 12:33

SCOTT-HAMILTON added 3 commits September 3, 2020 14:38

python-keystoneclient: init at 4.1.0

b97349a

debtcollector: init at 2.2.0

b33606c

keystoneauth1: init at 4.2.1

d05b583

SCOTT-HAMILTON added 5 commits September 3, 2020 14:38

os-service-types: init at 1.7.0

0db32ea

oslo-config: init at 8.3.1

1bb591c

oslo-i18n: init at 5.0.0

7a8a060

oslo-serialization: init at 4.0.0

6ad8bfb

oslo-utils: init at 4.4.0

ab86760

SCOTT-HAMILTON force-pushed the python-keystoneclient branch from 6b06d7e to ab86760 Compare September 3, 2020 13:04

jonringer reviewed Sep 3, 2020

View reviewed changes

SCOTT-HAMILTON closed this Feb 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python-keystoneclient: Init at 4.1.0 (+ all openstack dependencies) #96624

python-keystoneclient: Init at 4.1.0 (+ all openstack dependencies) #96624

SCOTT-HAMILTON commented Aug 29, 2020

SCOTT-HAMILTON commented Aug 29, 2020

catern left a comment

FRidh left a comment

jonringer commented Aug 31, 2020

SCOTT-HAMILTON commented Sep 1, 2020

SCOTT-HAMILTON commented Sep 2, 2020

SCOTT-HAMILTON commented Sep 2, 2020 •

edited

catern commented Sep 2, 2020

SCOTT-HAMILTON commented Sep 3, 2020

SCOTT-HAMILTON commented Sep 3, 2020

jonringer Sep 3, 2020

SCOTT-HAMILTON Sep 4, 2020

jonringer Sep 3, 2020

jonringer Sep 3, 2020

jonringer Sep 3, 2020

jonringer Sep 3, 2020

jonringer Sep 3, 2020

jonringer Sep 3, 2020

jonringer Sep 3, 2020

jonringer Sep 3, 2020

jonringer Sep 3, 2020

SCOTT-HAMILTON commented Sep 4, 2020

FRidh commented Sep 4, 2020 •

edited

FRidh commented Sep 20, 2020

nixos-discourse commented Sep 20, 2020

SuperSandro2000 commented Jan 18, 2021

SCOTT-HAMILTON commented Feb 22, 2021

		python-keystoneclient = disabledIf (!pythonOlder "3.8") (callPackage ../development/python-modules/python-keystoneclient { });

python-keystoneclient: Init at 4.1.0 (+ all openstack dependencies) #96624

python-keystoneclient: Init at 4.1.0 (+ all openstack dependencies) #96624

Conversation

SCOTT-HAMILTON commented Aug 29, 2020

Motivation for this change

Things done

SCOTT-HAMILTON commented Aug 29, 2020

catern left a comment

Choose a reason for hiding this comment

FRidh left a comment

Choose a reason for hiding this comment

jonringer commented Aug 31, 2020

SCOTT-HAMILTON commented Sep 1, 2020

SCOTT-HAMILTON commented Sep 2, 2020

SCOTT-HAMILTON commented Sep 2, 2020 • edited

catern commented Sep 2, 2020

SCOTT-HAMILTON commented Sep 3, 2020

SCOTT-HAMILTON commented Sep 3, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SCOTT-HAMILTON commented Sep 4, 2020

FRidh commented Sep 4, 2020 • edited

FRidh commented Sep 20, 2020

nixos-discourse commented Sep 20, 2020

SuperSandro2000 commented Jan 18, 2021

SCOTT-HAMILTON commented Feb 22, 2021

SCOTT-HAMILTON commented Sep 2, 2020 •

edited

FRidh commented Sep 4, 2020 •

edited