Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

androidStudioPackages.{dev,canary}: 4.2.0.7 -> 4.2.0.8 #96573

Merged
merged 1 commit into from Aug 30, 2020
Merged

androidStudioPackages.{dev,canary}: 4.2.0.7 -> 4.2.0.8 #96573

merged 1 commit into from Aug 30, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Aug 28, 2020

Tested building a project and running in the emulator.

@ghost
Copy link
Author

ghost commented Aug 29, 2020

@primeos

@Galagora
Copy link
Contributor

Galagora commented Aug 30, 2020 •
edited

Hey @meutraa, could you take over the beta branch? Downloading new versions takes very long (slow net + distant servers) and using them is annoying (because of the sway issues). Also, I now use Canary anyways (because of Jetpack compose). Remove me in the update to RC 1.

Also, if you're interested, you could probably automate the whole update process by configuring a VM (see nixos/tests) then using accessibility APIs (much easier and more reliable than raw input events) to control Studio (check out LDTP).

And if the reviews are taking long, check out the NixOS Discord's pr-review-request channel.

@ghost
Copy link
Author

ghost commented Aug 30, 2020

@Galagora I can. It does not take much time for me to do.

If there is anything reliable and consistent in this world, it is not android-studio.

The reviews do not bother me much because I can just use it from my local repository.

@primeos primeos merged commit 4d851ae into NixOS:master Aug 30, 2020
@primeos
Copy link
Member

primeos commented Aug 30, 2020

Thanks!

@ghost ghost mentioned this pull request Aug 31, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Galagora @primeos @meutraa