pythonPackages.(datasette, mergedeep, asgi-csrf, starlette, httpx, httpcore): upgrades & new additions #96565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build python37Packages.datasette python37Packages.fastapi google-music-scripts |
|
Hmm is the aarch64 failure just |
|
Builds for me. |
wd15
approved these changes
Aug 31, 2020
|
sorry, I sorted python-packages, please rebase |
slim down some no longer needed dependencies
remove outdated comment
risicle
force-pushed
the
ris-datasette-0.46
branch
from
b380de4
to
ba22c3c
Compare
wd15
approved these changes
Sep 1, 2020
jonringer
reviewed
Sep 1, 2020
enable more tests that now seem to work
risicle
force-pushed
the
ris-datasette-0.46
branch
from
ba22c3c
to
fce2ee2
Compare
jonringer
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
diff LGTM
https://github.com/NixOS/nixpkgs/pull/96565
17 packages built:
datasette google-music-scripts python37Packages.asgi-csrf python37Packages.datasette python37Packages.fastapi python37Packages.google-music python37Packages.httpcore python37Packages.httpx python37Packages.mergedeep python37Packages.starlette python38Packages.asgi-csrf python38Packages.fastapi python38Packages.google-music python38Packages.httpcore python38Packages.httpx python38Packages.mergedeep python38Packages.starlette
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This started with me upgrading
datasettefrom 0.39 -> 0.46, in an attempt to mitigate GHSA-q6j3-c4wc-63vw.This required the addition of
mergedeepandasgi-csrf.The addition of
asgi-csrfrequired a bump ofstarletteandhttpxto get the tests to pass.The bump of
httpxrequired the addition ofhttpcore.It's been a fun few evenings.
In the bumped packages I also performed a few cleanups, looking for no-longer-necessary dependencies, removing outdated comments etc.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)