Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnvim: add librsvg #96552

Closed
wants to merge 1 commit into from
Closed

gnvim: add librsvg #96552

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

closes: #96340

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

cc @ishan9299

@jonringer
Copy link
Contributor Author

this might not be right, I don't see librsvg being included in the ELF, may have to patchelf --set-rpath

@jtojnar
Copy link
Contributor

jtojnar commented Aug 28, 2020

You probably want librsvg's gdk-pixbuf module to be added to GDK_PIXBUF_MODULE_FILE env var. See wrapGAppsHook and strictDeps = false.

@jonringer
Copy link
Contributor Author

perhaps

@jonringer
Copy link
Contributor Author

better? I don't use a DE, so this is all shots in the dark for me

@jonringer
Copy link
Contributor Author

regardless if I add librsvg or gdk_pixbuf to buildInputs, it doesn't seem to be collected by wrapGApps

#! /nix/store/npfsrhkjww5q7sax7p7ijcrj3wlbrxn7-bash-4.4-p23/bin/bash -e
export PATH='/nix/store/gk48n21i9fmrp6v4fqv3j2klvf3792xi-neovim-0.4.4/bin'${PATH:+':'}$PATH
export GNVIM_RUNTIME_PATH='/nix/store/nigp3yyc57shhr24qv2295db25gzxmnp-gnvim-unwrapped-0.1.6/share/gnvim/runtime'
export GIO_EXTRA_MODULES='/nix/store/q6c030cihb85dvp1sf4zra3i9mq66c68-dconf-0.36.0-lib/lib/gio/modules'${GIO_EXTRA_MODULES:+':'}$GIO_EXTRA_MODULES
export GIO_EXTRA_MODULES='/nix/store/q6c030cihb85dvp1sf4zra3i9mq66c68-dconf-0.36.0-lib/lib/gio/modules'${GIO_EXTRA_MODULES:+':'}$GIO_EXTRA_MODULES
e

@jtojnar
Copy link
Contributor

jtojnar commented Aug 28, 2020

Oh, you are overriding buildCommand so the generic builder is not used and setup hooks will not run. See also #84913

@jonringer
Copy link
Contributor Author

ah, good catch, didn't really realize that either, thought this would be an easier issue to solve

@stale

This comment has been minimized.

Sign in to view
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 5, 2021
@SuperSandro2000
Copy link
Member

@ofborg eval

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 21, 2021
@teto
Copy link
Member

teto commented Mar 22, 2021

this still crashes for me

@SuperSandro2000 SuperSandro2000 marked this pull request as draft April 6, 2021 00:49
@jonringer
Copy link
Contributor Author

closing due to lack of interest, if a maintainer of the package could like to do so, please do.

@jonringer jonringer closed this Apr 8, 2021
@jtojnar jtojnar mentioned this pull request May 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@figsoda figsoda Awaiting requested review from figsoda figsoda will be requested when the pull request is marked ready for review figsoda is a code owner

@teto teto Awaiting requested review from teto teto will be requested when the pull request is marked ready for review teto is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gnvim crashes outside Nixos
4 participants
@jonringer @jtojnar @SuperSandro2000 @teto